Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ovsp4rt] Reference issues in TODO comments #690

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[ovsp4rt] Reference issues in TODO comments #690

merged 1 commit into from
Sep 16, 2024

Conversation

ffoulkes
Copy link
Contributor

  • A number of TODO comments were added to the code during unit test development, to mark apparent problems in the encoding of certain action parameter and match key values. Annotated these comments with links to the corresponding GitHub Issues.

@ffoulkes
[ovsp4rt] Reference issues in TODO comments
096d962 
- A number of TODO comments were added to the code during unit
  test development, to mark apparent problems in the encoding
  of certain action parameter and match key values. Annotated
  these comments with links to the corresponding GitHub Issues.

Signed-off-by: Derek Foster <derek.foster@intel.com>
@ffoulkes ffoulkes added documentation Improvements or additions to documentation minor effort Minimal effort required labels Sep 16, 2024
5abeel
5abeel approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit d52117e into main Sep 16, 2024
11 checks passed
@ffoulkes ffoulkes deleted the annotate-issues branch September 16, 2024 21:36
ffoulkes added a commit that referenced this pull request Sep 28, 2024
@ffoulkes
[ovsp4rt] Reference issues in TODO comments (#690)
879bd11 
- A number of TODO comments were added to the code during unit
  test development, to mark apparent problems in the encoding
  of certain action parameter and match key values. Annotated
  these comments with links to the corresponding GitHub Issues.

Signed-off-by: Derek Foster <derek.foster@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5abeel 5abeel 5abeel approved these changes

@n-sandeep n-sandeep Awaiting requested review from n-sandeep n-sandeep is a code owner

@vsureshkumarp vsureshkumarp Awaiting requested review from vsureshkumarp vsureshkumarp is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation minor effort Minimal effort required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffoulkes @5abeel