records_relations: Set default sort_by to None in configs

inveniosoftware · Apr 4, 2024 · 281494a · 281494a
1 parent 5b1bb6b
commit 281494a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/invenio_app_ils/records_relations/retriever.py b/invenio_app_ils/records_relations/retriever.py
@@ -173,9 +173,10 @@ def get(self):
 
             # Pre-requisite: fields being sorted should be of the same type.
             # Sort by the keys available in the data in order
-            relations.get(name, []).sort(
-                key=lambda rec: [rec.get(key) for key in relation_type.sort_by]
-            )
+            if relation_type.sort_by:
+                relations.get(name, []).sort(
+                    key=lambda rec: [rec.get(key) for key in relation_type.sort_by]
+                )
 
         return relations
 

diff --git a/invenio_app_ils/relations/api.py b/invenio_app_ils/relations/api.py
@@ -27,7 +27,7 @@
     "invenio_app_ils.relations.nodes:PIDNodeRelated",
     "invenio_pidrelations.serializers.schemas.RelationSchema",
     "invenio_app_ils.relations.api.SiblingsRelation",
-    [],
+    None,
 )
 EDITION_RELATION = ILS_RELATION_TYPE(
     1,
@@ -45,7 +45,7 @@
     "invenio_app_ils.relations.nodes:PIDNodeRelated",
     "invenio_pidrelations.serializers.schemas.RelationSchema",
     "invenio_app_ils.relations.api.SiblingsRelation",
-    [],
+    None,
 )
 MULTIPART_MONOGRAPH_RELATION = ILS_RELATION_TYPE(
     3,
@@ -54,7 +54,7 @@
     "invenio_app_ils.relations.nodes:PIDNodeRelated",
     "invenio_pidrelations.serializers.schemas.RelationSchema",
     "invenio_app_ils.relations.api.ParentChildRelation",
-    [],
+    None,
 )
 SERIAL_RELATION = ILS_RELATION_TYPE(
     4,
@@ -63,7 +63,7 @@
     "invenio_app_ils.relations.nodes:PIDNodeRelated",
     "invenio_pidrelations.serializers.schemas.RelationSchema",
     "invenio_app_ils.relations.api.ParentChildRelation",
-    [],
+    None,
 )
 SEQUENCE_RELATION = ILS_RELATION_TYPE(
     5,
@@ -72,7 +72,7 @@
     "invenio_app_ils.relations.nodes:PIDNodeRelated",
     "invenio_pidrelations.serializers.schemas.RelationSchema",
     "invenio_app_ils.relations.api.SequenceRelation",
-    [],
+    None,
 )