tests: loan request: fix test for minimum days before request

tests/api/circulation/test_loan_request.py

@@ -261,18 +261,8 @@ def test_request_loan_minimum_days(app, client, json_headers, users, testdata):
     assert res.status_code == 400
     assert res.get_json()["message"] == "Validation error."
 
-    params["document_pid"] = "docid-7"
-    end_date = (now + timedelta(days=4)).date().isoformat()  # PASS
-    params["request_expire_date"] = end_date
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "PENDING"
-    assert loan["document_pid"] == params["document_pid"]
-    assert loan["transaction_date"]
-
     params["document_pid"] = "docid-8"
-    end_date = (now + timedelta(days=8)).date().isoformat()  # PASS
+    end_date = (now + timedelta(days=7)).date().isoformat()  # PASS
     params["request_expire_date"] = end_date
     res = client.post(url, headers=json_headers, data=json.dumps(params))
     assert res.status_code == 202
@@ -299,17 +289,18 @@ def test_request_loan_minimum_days(app, client, json_headers, users, testdata):
 
     app.config["ILS_CIRCULATION_LOAN_REQUEST_OFFSET"] = 2
 
-    params["document_pid"] = "docid-11"
     start_date_friday = now + timedelta(days=(4 - now.weekday() + 7) % 7)
-    params["request_start_date"] = start_date_friday
+    params["request_start_date"] = start_date_friday.date().isoformat()
 
-    end_date_monday = (now + timedelta(days=3)).date().isoformat()  # FAIL
+    params["document_pid"] = "docid-11"
+    end_date_monday = (start_date_friday + timedelta(days=3)).date().isoformat()  # FAIL
     params["request_expire_date"] = end_date_monday
     res = client.post(url, headers=json_headers, data=json.dumps(params))
     assert res.status_code == 400
     assert res.get_json()["message"] == "Validation error."
 
-    end_date_tuesday = (now + timedelta(days=4)).date().isoformat()  # PASS
+    params["document_pid"] = "docid-12"
+    end_date_tuesday = (start_date_friday + timedelta(days=4)).date().isoformat()  # PASS
     params["request_expire_date"] = end_date_tuesday
     res = client.post(url, headers=json_headers, data=json.dumps(params))
     assert res.status_code == 202