Refine XCCL build option #1443
Merged
Refine XCCL build option #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guangyey
force-pushed
the
guangyey/oneccl_fix
branch
from
2d4fd2c to
7d1e00d
Compare
guangyey
changed the title
EikanWang
approved these changes
Mar 11, 2025
|
The failure is irrelevant. Show Failed cases in op_regression
=========================================================================
test_torchvision_roi_ops.py::TestRoIAlign::test_autocast[rois_dtype1-x_dtype0-True-True]
test_torchvision_roi_ops.py::TestRoIAlign::test_autocast[rois_dtype1-x_dtype0-True-False] |
# Motivation Prior to this PR, building PyTorch XPU with CCL distribution support required setting `USE_XCCL=ON USE_C10D_XCCL=ON python setup.py install`. With this PR, it only requires `USE_XCCL=ON python setup.py install`, simplifying the process. (cherry picked from commit d799bd3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
cherry pick from #1421
Prior to this PR, building PyTorch XPU with CCL distribution support required setting
USE_XCCL=ON USE_C10D_XCCL=ON python setup.py install.With this PR, it only requires
USE_XCCL=ON python setup.py install, simplifying the process.