Fix when USE_C10D_XCCL define in pytorch will not correct update cache #1441
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guangyey
reviewed
Mar 7, 2025
CMakeLists.txt
Outdated
| @@ -68,6 +68,8 @@ endif() | |||
| if(USE_DISTRIBUTED AND USE_XCCL AND USE_C10D_XCCL) | |||
| caffe2_update_option(USE_C10D_XCCL ON) | |||
| else() | |||
| # WA for USE_C10D_XCCL duplicated definition, will remove it after USE_C10D_XCCL and USE_XCCL define in PyTorch | |||
| set(USE_C10D_XCCL OFF CACHE BOOL "Build with XCCL support for C10D" FORCE) | |||
There was a problem hiding this comment.
Is it OK to only change line 43 to cmake_dependent_option(USE_C10D_XCCL "USE C10D XCCL" ON "USE_DISTRIBUTED;USE_XCCL" OFF)
It seems that it is legal to use cmake_dependent_option multiple times.
There was a problem hiding this comment.
I agree, this is a better approach.
guangyey
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Please have a try on local machine to make sure this is compatible with pytorch/pytorch#147593 in the following scenarios:
python setup.py installUSE_CCL=ON python setup.py installwith souring oneccl envUSE_CCL=ON python setup.py installwithout sourcing oneccl env
It works well
|
guangyey
pushed a commit
that referenced
this pull request
Mar 10, 2025
#1441) This pr for fix use_xccl and use_c10_xccl define in pytorch raise build error pytorch/pytorch#147593 After pytorch pr land, we will remove torch-xpu-ops defination. (cherry picked from commit 56e7dda)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr for fix use_xccl and use_c10_xccl define in pytorch raise build error
pytorch/pytorch#147593
After pytorch pr land, we will remove torch-xpu-ops defination.