Remove unnecessary static library installation for wheel packaging #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengyuan14
reviewed
Mar 6, 2025
Comment on lines
+269
to
+272
| string(REGEX MATCH "Norm" IS_NORM ${sycl_src}) | ||
| string(REGEX MATCH "Loss" IS_LOSS ${sycl_src}) | ||
| string(REGEX MATCH "Resize" IS_RESIZE ${sycl_src}) | ||
| string(REGEX MATCH "Distribution" IS_DISTRIBUTION ${sycl_src}) |
There was a problem hiding this comment.
Add more files to ATen_XPU_SYCL_COMMON_SRCS to balance the number of files with ATen_XPU_SYCL_OTHERS_SRCS.
xytintel
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of unnecessary static libraries (.lib files) being installed into the lib directory and subsequently included in the wheel package. Since wheel packages do not require .lib files, the related install statements have been removed to reduce the overall package size.