Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable pt2e test #1412

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

enable pt2e test #1412

wants to merge 14 commits into from

Conversation

kaileiyx
Copy link

No description provided.

@mengfei25 mengfei25 requested a review from chuanqi129 February 26, 2025 08:44
This was referenced Feb 26, 2025
@mengfei25 mengfei25 requested a review from chuanqi129 February 27, 2025 08:22
Copy link
Contributor

@chuanqi129 chuanqi129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments and launch a ondemand test before the PR merge @mengfei25 @kaileiyx

@mengfei25 mengfei25 requested a review from chuanqi129 February 28, 2025 07:45
@kaileiyx
Copy link
Author

kaileiyx commented Mar 1, 2025

Run PT2E full test and the artifact is the result of test. https://github.com/kaileiyx/torch-xpu-ops/actions/runs/13583874864

@chuanqi129
Copy link
Contributor

Run PT2E full test and the artifact is the result of test. https://github.com/kaileiyx/torch-xpu-ops/actions/runs/13583874864

Hi @kaileiyx, the on-demand test failed on summary part, please double check it

@kaileiyx
Copy link
Author

kaileiyx commented Mar 5, 2025

At present, only a simple result summary has been done. https://github.com/kaileiyx/torch-xpu-ops/actions/runs/13646119310

Copy link
Contributor

@chuanqi129 chuanqi129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Please consider that for those 3 on-demands test workflow deal with invalid config in next PR, such as we specific suite has hf/tb/tm but dt has int8 or suite has pt2e but dt has amp/bf16/fp16
@mengfei25 @kaileiyx

@chuanqi129
Copy link
Contributor

@kaileiyx please fix the lint error

@chuanqi129
Copy link
Contributor

@kaileiyx seems there is still 1 lint error, please address it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants