Map device_id to OV LUID #614
Open
+31
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preetha-intel
requested review from
sfatimar,
TejalKhade28,
vthaniel and
jatinwadhwa921
|
@preetha-intel . Can you please capture usage of this feature in the description on how to pass in the LUID. |
vthaniel
requested changes
Mar 11, 2025
| if (device_name == "No_match_found") { | ||
| ORT_THROW(" [ERROR] [OpenVINO] Invalid LUID. No matching hardware is found"); | ||
| } else { | ||
| pi.device_type = device_name; |
There was a problem hiding this comment.
What happens when user provides a "device_type" and "device_id" that are mismatching?
For example, the user passes "device_type" as "CPU" and
"device_id" as the "LUID of a valid GPU"
There was a problem hiding this comment.
Expected behavior should be, the LUID would be only checked for expected device_type.
So, in the above example CPU LUID either would not exist or will not match with LUID provided in device_id. Execution should error out saying "Device_Id not found in device_type- CPU."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for passing LUID via device_id provider option and map it with appropriate GPU device using OV get_property