Reshape feature implementation #573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfatimar
force-pushed
the
ovep-develop
branch
from
059f7c1 to
f84614c
Compare
ankitm3k
force-pushed
the
ovep-develop
branch
3 times, most recently
from
b66301b to
e93f0b0
Compare
jatinwadhwa921
force-pushed
the
jatin_latest_reshape_refactor
branch
2 times, most recently
from
53278fe to
be37fd9
Compare
ankitm3k
force-pushed
the
ovep-develop
branch
2 times, most recently
from
42d6f14 to
e85411a
Compare
|
@jatinwadhwa921 please update this branch |
sure, i will rebase this branch again with latest ovep-develop |
jatinwadhwa921
force-pushed
the
jatin_latest_reshape_refactor
branch
from
be37fd9 to
ca2bc91
Compare
sfatimar
reviewed
Mar 4, 2025
| @@ -236,6 +236,97 @@ struct OpenVINO_Provider : Provider { | |||
|
|
|||
| pi.precision = ParsePrecision(provider_options, pi.device_type, "precision"); | |||
|
|
|||
| if (provider_options.contains("reshape_input") && pi.device_type == "NPU") { | |||
There was a problem hiding this comment.
@jatinwadhwa921 exactly what are we trying to do here
There was a problem hiding this comment.
I am not comfortable leaving so much parsing in main functions can we create a file parse_utils.cc and dump all parsing functions there
|
@preetha-intel @ankitm3k can you please review this PR |
|
I would expect all parsing functions inside openvino_provider_factory to move to parse utils. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reshape feature implementation, This feature will help you set lower and upper bound for ov tensors only for NPU. Command used to run the feature -
onnxruntime_perf_test.exe -v -e openvino -m times -r 1 -i "device_type|NPU reshape_input|data[1,3,60,80..120]" <model_path>