Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only validate URL if provided in proto file for System Software Update #648

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Only validate URL if provided in proto file for System Software Update #648

merged 1 commit into from
Mar 4, 2025

Conversation

nmgaston
Copy link
Contributor

@nmgaston nmgaston commented Mar 4, 2025 •
edited
Loading

PULL DESCRIPTION

Extra fix needed for NEXMANAGE-1280. Need to only check for a valid URL if it is present.

Impact Analysis

Info Please fill out this column
Root Cause Extra fix for URL being required for System Software Update
Jira ticket NEXMANAGE-1280

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@nmgaston nmgaston marked this pull request as ready for review March 4, 2025 04:45
@nmgaston nmgaston requested a review from gblewis1 as a code owner March 4, 2025 04:45
@nmgaston nmgaston requested a review from yengliong93 March 4, 2025 04:46
@nmgaston nmgaston merged commit 02aad11 into develop Mar 4, 2025
7 of 8 checks passed
@nmgaston nmgaston deleted the NEXMANAGE-1280-3 branch March 4, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yengliong93 yengliong93 yengliong93 approved these changes

@gblewis1 gblewis1 Awaiting requested review from gblewis1 gblewis1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmgaston @yengliong93