Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Software Update URL and Release Date fields should not be required #644

Merged
merged 5 commits into from
Mar 4, 2025

Conversation

nmgaston
Copy link
Contributor

@nmgaston nmgaston commented Feb 28, 2025

PULL DESCRIPTION

Changes the URL and Release Date to optional for Software Update in the common.proto file.
Utilizes the validate.proto file that is also used in UDM.

Impact Analysis

Info Please fill out this column
Root Cause URL and ReleaseDate were set to required for Software Update when they should be optional
Jira ticket NEXMANAGE-1280

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@nmgaston nmgaston requested a review from gblewis1 as a code owner February 28, 2025 21:07
@nmgaston nmgaston marked this pull request as draft March 4, 2025 01:32
@nmgaston nmgaston marked this pull request as ready for review March 4, 2025 03:17
@nmgaston nmgaston requested a review from yengliong93 March 4, 2025 03:20
@nmgaston nmgaston merged commit 3c129f4 into develop Mar 4, 2025
7 checks passed
@nmgaston nmgaston deleted the NEXMANAGE-1280 branch March 4, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants