Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double cert prompt during provision-tc #638

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

gblewis1
Copy link
Contributor

@gblewis1 gblewis1 commented Feb 18, 2025

PULL DESCRIPTION

Prompt for 'do you want to require certs for OTA' appears twice during provision-tc. This PR fixes that.

Impact Analysis

Info Please fill out this column
Root Cause mistake when adding UDM mode to provision-tc
Jira ticket n/a

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog -- no update needed as this fixes bug introduced in same release
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@gblewis1 gblewis1 marked this pull request as ready for review February 25, 2025 19:30
@gblewis1 gblewis1 requested a review from nmgaston as a code owner February 25, 2025 19:30
@gblewis1 gblewis1 merged commit 0238938 into develop Feb 27, 2025
7 checks passed
@gblewis1 gblewis1 deleted the gblewis1/fix-double-cert-prompt-during-provision-tc branch February 27, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants