-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes of local build of gprofiler executable #941
Conversation
…t on aarch64 and windows; (3) fixed case when perfspect metrics are not collected
…into fixes_for_build
Do you think we can merge this now? |
We need to discuss changes with "--trusted-host files.pythonhosted.org --trusted-host pypi.org" in docker file with @mlim19. |
This patchset combines 2 things: Ron's patch for workaround the proxy issue and our patch for initial perfspect integration which I think not mature yet to merge. And they should be split and merged separately when ready. Regarding Ron's patch, I believe the pip config change seems more suitable for proxy users which is described at https://stackoverflow.com/questions/25981703/pip-install-fails-with-connection-error-ssl-certificate-verify-failed-certi |
I agree that it makes sense to split these up, with the proxy workaround going first. The reasons for asking is that I want to close out the remaining CVEs without disrupting the process. I will work from this branch for now. |
Let me split changes, I will prepare PR to enable_perfspec_metrics branch with changes related only to perfspect integration. |
PR with changes related only to Perfspect integration: |
Added small changes to fix issues that we faced with build locally. It will be useful to have these changes in branch also, for easier development.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots
Checklist: