Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update setuptools and pip to resolve trivy vulnerabilities #380

Merged
merged 7 commits into from
Sep 12, 2024

Conversation

sramakintel
Copy link
Contributor

@sramakintel sramakintel commented Sep 12, 2024

Description

Fix vulnerabilities in serve container

Related Issue

Changes Made

  • The code follows the project's coding standards.
  • No Intel Internal IP is present within the changes.
  • The documentation has been updated to reflect any changes in functionality.

Validation

  • I have tested any changes in container groups locally with test_runner.py with all existing tests passing, and I have added new tests where applicable.

Signed-off-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
Signed-off-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
@sramakintel sramakintel changed the title Sramakr1/update packages update packages Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 3 package(s) with unknown licenses.
See the Details below.

License Issues

pytorch/venv-requirements.txt

PackageVersionLicenseIssue Type
intel-openmp2024.2.1NullUnknown License
mkl-include2024.2.1NullUnknown License
mkl2024.2.1NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
pip/numpy 2.1.1 🟢 7.9
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection🟢 3branch protection is not maximal on development and all release branches
CI-Tests🟢 1013 out of 13 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Code-Review🟢 10all changesets reviewed
Contributors🟢 10project has 93 contributing companies or organizations
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing🟢 10project is fuzzed
License🟢 9license file detected
Maintained🟢 1030 commit(s) and 18 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
SAST🟢 9SAST tool detected but not run on all commits
Security-Policy🟢 9security policy file detected
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
Token-Permissions🟢 9detected GitHub workflow tokens with excessive permissions
Vulnerabilities🟢 100 existing vulnerabilities detected
pip/intel-openmp 2024.2.1 UnknownUnknown
pip/mkl 2024.2.1 UnknownUnknown
pip/mkl-include 2024.2.1 UnknownUnknown
pip/psutil 6.0.0 🟢 5.8
Details
CheckScoreReason
Maintained🟢 106 commit(s) and 7 issue activity found in the last 90 days -- score normalized to 10
Code-Review⚠️ 2Found 8/30 approved changesets -- score normalized to 2
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 10security policy file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing🟢 10project is fuzzed
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
pip/setuptools >= 70.0.0 🟢 4.9
Details
CheckScoreReason
Code-Review⚠️ 0Found 1/12 approved changesets -- score normalized to 0
Maintained🟢 1030 commit(s) and 14 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Packaging⚠️ -1packaging workflow not detected
Security-Policy🟢 10security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Binary-Artifacts⚠️ 2binaries present in source code
Vulnerabilities🟢 100 existing vulnerabilities detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing🟢 10project is fuzzed
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Manifest Files

pytorch/serving/torchserve-xpu-requirements.txt
  • numpy@2.1.1
  • numpy@1.26.4
pytorch/venv-requirements.txt
  • intel-openmp@2024.2.1
  • mkl@2024.2.1
  • mkl-include@2024.2.1
  • psutil@6.0.0
  • setuptools@>= 70.0.0

Signed-off-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
Signed-off-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
@sramakintel sramakintel self-assigned this Sep 12, 2024
@sramakintel sramakintel changed the title update packages update setuptools and pip to resolve trivy vulnerabilities Sep 12, 2024
tylertitsworth
tylertitsworth previously approved these changes Sep 12, 2024
Signed-off-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@tylertitsworth tylertitsworth merged commit 5b55cc1 into main Sep 12, 2024
42 of 44 checks passed
@tylertitsworth tylertitsworth deleted the sramakr1/update_packages branch September 12, 2024 22:24
tylertitsworth pushed a commit that referenced this pull request Sep 25, 2024
Signed-off-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants