-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Perf Sample Example Section #307
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
99d9de5
Add Perf Sample Example Section
e194d63
Merge branch 'main' into tylertitsworth/perf-sample-ex
d4e0f3d
Update README.md
0deb8ef
Update README.md
f1d7cfa
Update README.md
tylertitsworth 4b9065c
Merge branch 'main' into tylertitsworth/perf-sample-ex
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ The images below include variations for only the core packages in the [Intel® D | |
|
||
## Build from Source | ||
|
||
To build the images from source, clone the [Intel® AI Containers](https://github.com/intel/ai-containers) repository, follow the main `README.md` file to setup your environment, and run the following command: | ||
To build the images from source, clone the [Intel® AI Containers](https://github.com/intel/ai-containers) repository, follow the main `README.md` file to setup your environment, and run the following commands: | ||
|
||
```bash | ||
cd python | ||
|
@@ -30,6 +30,18 @@ You can find the list of services below for each container in the group: | |
| `idp` | Base image with [Intel® Distribution for Python] | | ||
| `pip` | Equivalent python image without [Intel® Distribution for Python] | | ||
|
||
## Run a Performance Sample | ||
|
||
To run a performance sample, clone the [Intel® AI Containers](https://github.com/intel/ai-containers) repository, follow the main `README.md` file to setup your environment, and run the following commands: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we don't expect our target users (who may be novice users) to follow the instructions in the main README of containers repo. Instead of it, we need to provide all the needed commands here (not for building from source, but for pulling and running the container). |
||
|
||
```bash | ||
cd python | ||
docker run --rm -it \ | ||
-v $PWD/tests:/tests \ | ||
intel/python:latest \ | ||
python /tests/perf_sample.py | ||
``` | ||
|
||
## License | ||
|
||
View the [License](https://github.com/intel/ai-containers/blob/main/LICENSE) for the [Intel® Distribution for Python]. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after discussion with Alex Rybkin, it seems like build from source option is not relevant for our target users. So, we probably should remove this section if there are no objections