Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSH port by default in multinode container #214

Merged
merged 16 commits into from
Jul 8, 2024

Conversation

sharvil10
Copy link
Contributor

This PR fixes the Port number by default in the multinode container.

Copy link

github-actions bot commented Jul 3, 2024

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

pytorch/multinode/requirements.txt

PackageVersionLicenseIssue Type
oneccl_bind_pt2.3.0+cpuNullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
pip/neural-compressor 2.6 🟢 6.3
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 7 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 9Found 29/30 approved changesets -- score normalized to 9
CII-Best-Practices⚠️ 2badge detected: InProgress
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Packaging⚠️ -1packaging workflow not detected
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy🟢 10security policy file detected
SAST🟢 9SAST tool is not run on all commits -- score normalized to 9
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Vulnerabilities⚠️ 090 existing vulnerabilities detected
pip/oneccl_bind_pt 2.3.0+cpu UnknownUnknown
pip/neural-compressor 2.6 🟢 6.3
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 7 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 9Found 29/30 approved changesets -- score normalized to 9
CII-Best-Practices⚠️ 2badge detected: InProgress
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Packaging⚠️ -1packaging workflow not detected
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy🟢 10security policy file detected
SAST🟢 9SAST tool is not run on all commits -- score normalized to 9
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Vulnerabilities⚠️ 090 existing vulnerabilities detected
pip/oneccl_bind_pt 2.3.0+cpu UnknownUnknown

Scanned Manifest Files

pytorch/multinode/requirements.txt
  • neural-compressor@2.6
  • oneccl_bind_pt@2.3.0+cpu
pytorch/multinode-requirements.txt
  • neural-compressor@2.6
  • oneccl_bind_pt@2.3.0+cpu

@tylertitsworth tylertitsworth force-pushed the sharvil/ssh-port-fix branch from 52e130c to 83774ad Compare July 3, 2024 22:53
Signed-off-by: tylertitsworth <tyler.titsworth@intel.com>
tylertitsworth
tylertitsworth previously approved these changes Jul 3, 2024
Signed-off-by: tylertitsworth <tyler.titsworth@intel.com>
Signed-off-by: tylertitsworth <tyler.titsworth@intel.com>
@tylertitsworth tylertitsworth self-assigned this Jul 3, 2024
sramakintel
sramakintel previously approved these changes Jul 3, 2024
Copy link
Contributor

@sramakintel sramakintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Tyler Titsworth added 2 commits July 3, 2024 22:05
Signed-off-by: Tyler Titsworth <tyler.titsworth@intel.com>
Signed-off-by: Tyler Titsworth <tyler.titsworth@intel.com>
@tylertitsworth tylertitsworth merged commit ed557c2 into main Jul 8, 2024
5 of 7 checks passed
@tylertitsworth tylertitsworth deleted the sharvil/ssh-port-fix branch July 8, 2024 18:57
sramakintel added a commit that referenced this pull request Jul 8, 2024
Signed-off-by: tylertitsworth <tyler.titsworth@intel.com>
Signed-off-by: Tyler Titsworth <tyler.titsworth@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: tylertitsworth <tyler.titsworth@intel.com>
Co-authored-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
Signed-off-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
dmsuehir pushed a commit that referenced this pull request Jul 12, 2024
Signed-off-by: tylertitsworth <tyler.titsworth@intel.com>
Signed-off-by: Tyler Titsworth <tyler.titsworth@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: tylertitsworth <tyler.titsworth@intel.com>
Co-authored-by: Srikanth Ramakrishna <srikanth.ramakrishna@intel.com>
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants