Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last image being used as a cover #4

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

mciszczon
Copy link
Member

@mciszczon mciszczon commented Oct 29, 2024

Fixes an improper usage of discussion.json_metatada.image?.pop() in favor of ...image[0] to return first image of the post as the cover.

@mciszczon mciszczon added the bug Something isn't working label Oct 29, 2024
@mciszczon mciszczon self-assigned this Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c9b6736) to head (55efb2f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines           36        96   +60     
=========================================
+ Hits            36        96   +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mciszczon mciszczon merged commit 91dae03 into main Oct 29, 2024
3 checks passed
@mciszczon mciszczon deleted the bug/last-image-as-cover branch October 29, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant