feat(component): support metadata filter in artifact component #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
==========================================
+ Coverage 19.22% 19.58% +0.36%
==========================================
Files 426 436 +10
Lines 84603 84957 +354
==========================================
+ Hits 16264 16642 +378
+ Misses 66002 65955 -47
- Partials 2337 2360 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvallesm
reviewed
Feb 25, 2025
There was a problem hiding this comment.
I did a post-merge review, the logic looks fine, I just detected a small typo in a struct definition 👍 LGTM
Thanks for re-generating the component documents, I think we should generate them automatically in the CI like in the code generated by the protobuf files. Something to keep in mind in the future.
| // The media type to filter | ||
| FileMediaType string `json:"file-media-type"` | ||
| // The content type to filter | ||
| ContetType string `json:"content-type"` |
There was a problem hiding this comment.
nit: small typo s/Contet/Content
jvallesm
pushed a commit
that referenced
this pull request
Feb 25, 2025
🤖 I have created a release *beep* *boop* --- ## [0.51.0-beta](v0.50.0-beta...v0.51.0-beta) (2025-02-25) ### Features * **all:** rename VDP to pipeline ([#963](#963)) ([8ba570a](8ba570a)) * **component:** support metadata filter in artifact component ([#979](#979)) ([624029a](624029a)) * **Docling:** prefetch model artifacts ([#964](#964)) ([c9ff323](c9ff323)) * **document:** convert PDF to Markdown with Docling ([#959](#959)) ([a9dbf55](a9dbf55)) * **document:** log execution times for benchmarking ([#969](#969)) ([ac3e2c3](ac3e2c3)) * **init:** remove preset pipeline downloader ([#970](#970)) ([11f8f5c](11f8f5c)) * **minio:** add client info and user header to artifact binary fetcher ([#978](#978)) ([78c9c1f](78c9c1f)) * **minio:** add service name and version to MinIO requests ([#976](#976)) ([39c66cd](39c66cd)) * **minio:** log MinIO actions with requester ([#972](#972)) ([8ba353e](8ba353e)) * **perplexity:** add new Sonar models ([#957](#957)) ([2699679](2699679)) * **recipe:** rename `format` to `type` in variable section ([#971](#971)) ([88ead91](88ead91)) * **x:** update MinIO package to delegate audit logs ([#973](#973)) ([f81287b](f81287b)) ### Bug Fixes * **ci:** registry image build ([#960](#960)) ([3a56698](3a56698)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
TASK_RETRIEVE