feat(minio): emit MinIO audit logs to artifact-backend #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
force-pushed
the
jvalles/ins-7319-log-requirements-for-ephi-data-access-and-modifications
branch
from
4a65ac3 to
b666cd4
Compare
jvallesm
requested review from
donch1989,
heiruwu and
Sarthak-instill
as code owners
jvallesm
commented
Feb 14, 2025
| @@ -1585,6 +1585,9 @@ milvus: | |||
| timeoutSeconds: 1 | |||
| successThreshold: 1 | |||
| failureThreshold: 5 | |||
| environment: | |||
| MINIO_AUDIT_WEBHOOK_ENABLE_ARTIFACT: "on" | |||
| MINIO_AUDIT_WEBHOOK_ENDPOINT_ARTIFACT: "http://core-artifact-backend:3082/v1alpha/minio-audit" | |||
There was a problem hiding this comment.
ℹ️ It'd be great to read the host and port from _helpers.tpl but I didn't manage to make that work. We plan to extract the minio definition from the Milvus child chart so this isn't critical now.
jvallesm
deleted the
jvalles/ins-7319-log-requirements-for-ephi-data-access-and-modifications
branch
jvallesm
pushed a commit
that referenced
this pull request
Feb 25, 2025
🤖 I have created a release *beep* *boop* --- ## [0.49.0-beta](v0.48.1-beta...v0.49.0-beta) (2025-02-25) ### Features * **minio:** emit MinIO audit logs to artifact-backend ([#1177](#1177)) ([1574988](1574988)) ### Bug Fixes * **test:** inject dummy OAuth values in integration tests ([#1172](#1172)) ([2540997](2540997)) * **workflow:** fix release helm chart github action workflow ([#1169](#1169)) ([616c6f1](616c6f1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
artifact-backendto ingest MinIO's audit logs and log the relevant information.