-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime metrics #7
Conversation
src/checkoutservice/main.go
Outdated
@@ -609,3 +617,64 @@ func (cs *checkoutService) getIntFeatureFlag(ctx context.Context, featureFlagNam | |||
|
|||
return int(featureFlagValue) | |||
} | |||
|
|||
func recordRuntimeMetrics(meter metric.Meter) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding these runtime metrics, can we follow the semcov spec from community?
https://opentelemetry.io/docs/specs/semconv/runtime/go-metrics/#go-goroutines.
The same applies to node.js.
For example: go_goroutines
, it is represented as go.goroutine.count
in community semcov.
src/checkoutservice/main.go
Outdated
@@ -10,10 +10,13 @@ import ( | |||
"net" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the purpose of completeness, besides Checkout Service, we probably also need to handle Product Catalog Service as another golang app by adding runtime metrics monitoring.
With that, shall we move runtime metrics monitoring code to a separate place so that can be reused by both two services?
# pipelines: | ||
# traces: | ||
# exporters: [spanmetrics, otlphttp/example] | ||
processors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking whether this should move to a separate folder, e.g.: /instana, just as Petr did, so that it's easy to merge updates from upstream later. The /instana folder can host any changes specific to Instana, including sample configuration, documents, etc.
Add more runtime metrics of go and nodejs application
Add nodejs auto instrumentation
f369b7a
to
77d1500
Compare
Move runtime metrics monitoring code to a separate place
Changes
Add runtime metrics in golang application and nodejs application for demo purpose.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.