Skip to content

Commit

Permalink
Remove collect metrics func to sdk process
Browse files Browse the repository at this point in the history
  • Loading branch information
liyanwei93 committed Nov 21, 2024
1 parent 3533656 commit d79e6a9
Show file tree
Hide file tree
Showing 3 changed files with 261 additions and 201 deletions.
4 changes: 0 additions & 4 deletions src/paymentservice/charge.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const { FlagdProvider} = require('@openfeature/flagd-provider');
const flagProvider = new FlagdProvider();

const logger = require('./logger');
const runtimeMetrics = require('./runtime-metrics');
const tracer = trace.getTracer('paymentservice');
const meter = metrics.getMeter('paymentservice');
const transactionsCounter = meter.createCounter('app.payment.transactions')
Expand Down Expand Up @@ -65,8 +64,5 @@ module.exports.charge = async request => {
const { units, nanos, currencyCode } = request.amount;
logger.info({transactionId, cardType, lastFourDigits, amount: { units, nanos, currencyCode }}, "Transaction complete.");
transactionsCounter.add(1, {"app.payment.currency": currencyCode})

runtimeMetrics.setupRuntimeMetrics();

return { transactionId }
}
4 changes: 3 additions & 1 deletion src/paymentservice/opentelemetry.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const {containerDetector} = require('@opentelemetry/resource-detector-container'
const {gcpDetector} = require('@opentelemetry/resource-detector-gcp')
const {envDetector, hostDetector, osDetector, processDetector} = require('@opentelemetry/resources')
const {RuntimeNodeInstrumentation} = require('@opentelemetry/instrumentation-runtime-node')
const { setSdkInstance } = require('./runtime-metrics');

const sdk = new opentelemetry.NodeSDK({
traceExporter: new OTLPTraceExporter(),
Expand Down Expand Up @@ -42,4 +43,5 @@ const sdk = new opentelemetry.NodeSDK({
],
})

sdk.start();
sdk.start();
setSdkInstance(sdk);
Loading

0 comments on commit d79e6a9

Please sign in to comment.