Fix e2e python env in nix shell for linux #522
Merged
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsporny
approved these changes
Feb 26, 2025
AmbientTea
approved these changes
Feb 26, 2025
alexromanov
approved these changes
Feb 26, 2025
This change extends the LD_LIBRARY_PATH to include libs required by numpy. This wouldn't be necessary if we were providing python packages through Nix but we aren't so we need to make them visible
Remove note about having to use a system installed python interpreter. The one provided by Nix works fine now.
gilligan
force-pushed
the
fix-linux-numpy
branch
from
2bb2065 to
ab10977
Compare
kpinter-iohk
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Works great, but since you updated the docs, there is another place where it is stated that Python doesn't work from Nix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the LD_LIBRARY_PATH to include libs required by numpy. This wouldn't be necessary if we were providing python packages through Nix but we aren't so we need to make them visible
Checklist
changelog.mdfor affected crate