Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Append block producer to log on block finalization #519

Merged
merged 6 commits into from
Feb 26, 2025

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Feb 25, 2025

Description

Adjustments for the block producer log pallet in anticipation of block reward payouts.

  • Adds peek_prefix and drop_prefix operations to the block production log pallet
  • Saves the block producer in a temporary storage and appends it to the block production log only in the on_finalize hook. This is to make the the prefix operations independent of pallet order in the runtime.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@AmbientTea AmbientTea marked this pull request as ready for review February 25, 2025 12:15
@AmbientTea AmbientTea force-pushed the append-block-producer-on-finalize branch from 93078bf to 2728c5b Compare February 25, 2025 15:50
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
@AmbientTea AmbientTea force-pushed the append-block-producer-on-finalize branch from 100d637 to 8e75bc8 Compare February 26, 2025 09:29
@AmbientTea AmbientTea enabled auto-merge (squash) February 26, 2025 09:29
@AmbientTea AmbientTea merged commit e88e46c into master Feb 26, 2025
23 checks passed
@AmbientTea AmbientTea deleted the append-block-producer-on-finalize branch February 26, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants