Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add another v-function in local-env #477

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rsporny
Copy link
Collaborator

@rsporny rsporny commented Feb 7, 2025

adds:

  • new v-function-updated.script that enables testing of ./partner-chains-node smart-contracts reserve update-settings command

@@ -1,5 +1,5 @@
{
"type": "PlutusScriptV2",
"description": "V-function that allows to release one token each minute since 2025-01-01 00:00 UTC (timestamp 1735689600)",
"description": "V-function that allows to release one token each minute since 1975-07-02 21:36 UTC (timestamp 000173568960)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy, I wish it was a fix in the function body, not in the description

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm automating some e2e tests for it. I'll probably add more v-functions and replace that with 01-01-2025 date

@@ -55,7 +55,7 @@ echo "Permissioned candidates policy ID: $PERMISSIONED_CANDIDATES_POLICY_ID"
echo "Setting values for NATIVE_TOKEN_POLICY_ID, NATIVE_TOKEN_ASSET_NAME, and ILLIQUID_SUPPLY_VALIDATOR_ADDRESS for chain-spec creation"
export NATIVE_TOKEN_POLICY_ID="1fab25f376bc49a181d03a869ee8eaa3157a3a3d242a619ca7995b2b"
export NATIVE_TOKEN_ASSET_NAME="52657761726420746f6b656e"
export ILLIQUID_SUPPLY_VALIDATOR_ADDRESS="addr_test1wpy8ewg646rg4ce78nl3aassmkquf4wlxcaugqlxwzcylkca0q8v3"
export ILLIQUID_SUPPLY_VALIDATOR_ADDRESS="addr_test1wq0mnff9xtddgxx8wjxt8sx68gxvf06yy2c60tqdgsp8ydsgvu7hq"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it because genesis_utxo changed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

@LGLO LGLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but expect me to come back to the first V-function and update timestamp.

@@ -0,0 +1,5 @@
{
"type": "PlutusScriptV2",
"description": "V-function that allows to release one token each minute since 2025-02-07 10:46 UTC (timestamp 1738925213000)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use something round, like 1st Feb, to make calculations easier? After all humans are supposed to use this setup. If this is only for E2E, then it should be moved there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I'll move it then

@rsporny rsporny force-pushed the new-v-function-to-test-update-settings branch 2 times, most recently from eb398a3 to b7bf26f Compare February 13, 2025 16:52
@rsporny rsporny marked this pull request as draft February 18, 2025 10:07
adds:
- new `v-function-updated.script` that enables testing of `./partner-chains-node smart-contracts reserve update-settings` command
@rsporny rsporny force-pushed the new-v-function-to-test-update-settings branch from b7bf26f to 5223915 Compare February 18, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants