Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relax validation of disallowedCategories of dapp-explorer feature flag payload [LW-12163] #1749

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: relax validation of disallowedCategories of dapp-explorer feature flag payload [LW-12163] #1749

wants to merge 1 commit into from
+54 −74

Conversation

szymonmaslowski
Copy link
Contributor

@szymonmaslowski szymonmaslowski commented Feb 28, 2025 •
edited
Loading

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

  • Removed allowed categories to be provided by the disallowedCategories property of the dapp-explorer FF payload
  • Slightly reorganised code by moving schema validation logic to the PostHogClient space where it is actually used

@szymonmaslowski szymonmaslowski requested a review from a team as a code owner February 28, 2025 12:10
@szymonmaslowski szymonmaslowski self-assigned this Feb 28, 2025
@szymonmaslowski szymonmaslowski changed the title fix: relax validation of disallowedCategories prop of dapp-explorer F… fix: relax validation of disallowedCategories of dapp-explorer feature flag payload [LW-12163] Feb 28, 2025
@szymonmaslowski szymonmaslowski force-pushed the fix/lw-12163-relax-disallowed-categories-validation branch from d418674 to b6eaee7 Compare February 28, 2025 13:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rhyslbw
rhyslbw reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a little hard to review since the two distinct changes are committed together. In future it would be best to move the code first (refactor type), then change its behaviour in a follow up commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhyslbw rhyslbw rhyslbw left review comments

@przemyslaw-wlodek przemyslaw-wlodek przemyslaw-wlodek approved these changes

Assignees

@szymonmaslowski szymonmaslowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szymonmaslowski @rhyslbw @przemyslaw-wlodek