fix: [lw-12362] view cbor in dapp confirmation #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
reviewed
Feb 26, 2025
| @@ -3,6 +3,8 @@ | |||
| "core.activityDetails.AuthorizeCommitteeHotCertificate": "Authorize Committee", | |||
| "core.activityDetails.certificate": "Certificate", | |||
| "core.activityDetails.certificates": "Certificates", | |||
| "core.activityDetails.CBOR.header": "Raw Transaction (CBOR)", | |||
| "core.activityDetails.CBOR.title": "Begin of data", | |||
There was a problem hiding this comment.
This wording is a little odd. Was it in the mockup? I don't see the need for the title
There was a problem hiding this comment.
Just confirmed with Ian this was an oversight in the mockup. Can you please drop the title, just leaving us with the header @vetalcore?
There was a problem hiding this comment.
done here 175cefe
vetalcore
force-pushed
the
feat/lw-12362-view-cbor-in-dapp-confirmation
branch
from
88bc646 to
afcacac
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots