-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(extension): [lw-10789] fix delegation tx summary #1245
fix(extension): [lw-10789] fix delegation tx summary #1245
Conversation
e6c56fa
to
688870c
Compare
Allure Report
smokeTests: ✅ test report for ac2dad7b
|
({ type, status }) => | ||
type && | ||
(type in DelegationActivityType || | ||
type === ConwayEraCertificatesTypes.Registration || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not add to the DelegationActivityType
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes an no, these are still conway era certs
i've run into the case when
@mkazlauskas i'm wondering if there was a particular performance degradation you were trying to fix by introducing memoization here, or i could safely remove it for now? |
Don't remember for sure, but I think yes there was. If I understand the issue correnctly, maybe you could do sth like |
688870c
to
ac2dad7
Compare
|
2a67a34
into
fix/lw-10782-map-conway-era-certificates
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes