Add default runner param to e2e split workflow (#1242)

input-output-hk · Jun 25, 2024 · e314238 · e314238
1 parent ff2fbbf
commit e314238
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 12 deletions.
diff --git a/.github/workflows/e2e-tests-linux-split.yml b/.github/workflows/e2e-tests-linux-split.yml
@@ -42,17 +42,16 @@ env:
 
 jobs:
   prereq:
-    runs-on: "${{ inputs.runner }}"
-    if: ${{ inputs.runner == 'self-hosted' }}
+    runs-on: ubuntu-latest
     steps:
-      - name: Deleting chrome tmp files
-        id: clean-chrome-tmp-files
+      - name: Provision step
         run: |
-          runCommand="rm -rf /tmp/.org.chromium.*"
-          eval "$runCommand";
+          echo "Provisioning ${{ github.event.inputs.runner }}"
+    outputs:
+      runner: ${{ github.event.inputs.runner || 'ubuntu-22.04' }}
 
   tests-run-part-1:
-    runs-on: "${{ inputs.runner }}"
+    runs-on: ${{ needs.prereq.outputs.runner }}
     if: always()
     needs: prereq
     steps:
@@ -88,7 +87,7 @@ jobs:
           path: ./packages/e2e-tests/reports/allure/results
 
   tests-run-part-2:
-    runs-on: "${{ inputs.runner }}"
+    runs-on: ${{ needs.prereq.outputs.runner }}
     if: always()
     needs: prereq
     steps:
@@ -124,7 +123,7 @@ jobs:
           path: ./packages/e2e-tests/reports/allure/results
 
   tests-run-part-3:
-    runs-on: "${{ inputs.runner }}"
+    runs-on: ${{ needs.prereq.outputs.runner }}
     if: always()
     needs: prereq
     steps:
@@ -160,7 +159,7 @@ jobs:
           path: ./packages/e2e-tests/reports/allure/results
 
   tests-run-part-4:
-    runs-on: "${{ inputs.runner }}"
+    runs-on: ${{ needs.prereq.outputs.runner }}
     if: always()
     needs: prereq
     steps:
@@ -197,7 +196,7 @@ jobs:
 
   results-processing:
     needs: [tests-run-part-1, tests-run-part-2, tests-run-part-3, tests-run-part-4]
-    runs-on: "${{ inputs.runner }}"
+    runs-on: 'self-hosted'
     if: always()
     steps:
       - name: Download reports from part 1
@@ -273,3 +272,9 @@ jobs:
           SLACK_TITLE: 'Test automation results :rocket:'
           SLACK_USERNAME: lace-qa-bot
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
+      - name: Deleting chrome tmp files
+        id: clean-chrome-tmp-files
+        if: ${{ needs.prereq.outputs.runner == 'self-hosted' }}
+        run: |
+          runCommand="rm -rf /tmp/.org.chromium.*"
+          eval "$runCommand";
diff --git a/packages/e2e-tests/src/features/TransactionsExtended.feature b/packages/e2e-tests/src/features/TransactionsExtended.feature
@@ -41,7 +41,7 @@ Feature: Transactions - Extended view
     When I navigate to Transactions extended page
     Then all transactions have icon, type of transaction, amount of tokens, value, and value in FIAT
 
-  @LW-2559 @Smoke @Testnet @Mainnet
+  @LW-2559 @Smoke @Testnet @Mainnet @Pending @issue=@LW-10788
   Scenario: Extended View - Transactions details - Folded
     Given I am on the Transactions section - Extended view
     When click on a transaction