fix: round Ada naturally

Ada naturally supports 6 decimal points, and we should be supporting this precision
input-output-hk · Sep 22, 2024 · 61c99c7 · 61c99c7
1 parent 48a74ad
commit 61c99c7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/...wallet/src/views/browser-view/features/send-transaction/components/Form/CoinInput/util.ts b/...wallet/src/views/browser-view/features/send-transaction/components/Form/CoinInput/util.ts
@@ -47,7 +47,7 @@ export const getADACoinProperties = (
 ): ADARow => {
   // Convert to ADA
   const availableADA = Wallet.util.lovelacesToAdaString(balance);
-  const spendableCoinInAda = Wallet.util.lovelacesToAdaString(spendableCoin, undefined, BigNumber.ROUND_DOWN);
+  const spendableCoinInAda = Wallet.util.lovelacesToAdaString(spendableCoin);
   // Calculate max amount in ADA
   const max = getMaxSpendableAmount(spendableCoinInAda, spentCoins, currentSpendingAmount);
   return {

diff --git a/packages/cardano/src/wallet/util/__tests__/unit-converters.test.ts b/packages/cardano/src/wallet/util/__tests__/unit-converters.test.ts
@@ -10,12 +10,7 @@ import {
 describe('Testing lovelacesToAdaString function', () => {
   test('should convert lovelaces to ada', async () => {
     const result = lovelacesToAdaString('1000000');
-    expect(result).toBe('1.00');
-  });
-
-  test('should return ada value with 4 decimals', async () => {
-    const result = lovelacesToAdaString('1000000', 4);
-    expect(result).toBe('1.0000');
+    expect(result).toBe('1');
   });
 });
 

diff --git a/packages/cardano/src/wallet/util/unit-converters.ts b/packages/cardano/src/wallet/util/unit-converters.ts
@@ -4,11 +4,8 @@ import { CoinId } from '../types';
 const LOVELACE_VALUE = 1_000_000;
 const DEFAULT_DECIMALS = 2;
 
-export const lovelacesToAdaString = (
-  lovelaces: string,
-  decimalValues: number = DEFAULT_DECIMALS,
-  roudingMode: BigNumber.RoundingMode = BigNumber.ROUND_HALF_UP
-): string => new BigNumber(lovelaces).dividedBy(LOVELACE_VALUE).toFixed(decimalValues, roudingMode);
+export const lovelacesToAdaString = (lovelaces: string): string =>
+  new BigNumber(lovelaces).dividedBy(LOVELACE_VALUE).toString();
 
 export const adaToLovelacesString = (ada: string): string => new BigNumber(ada).multipliedBy(LOVELACE_VALUE).toString();