Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): Import proposal #1929

Merged
merged 19 commits into from
Feb 28, 2025
Merged

feat(cat-voices): Import proposal #1929

merged 19 commits into from
Feb 28, 2025

Conversation

dtscalac
Copy link
Contributor

Description

  • Import exported proposal from workspace.

Related Issue(s)

Closes #1703

Screenshots

Successful import:
https://github.com/user-attachments/assets/667f394f-c4ae-4723-b75f-ec397d2bb86d

Failed import:
https://github.com/user-attachments/assets/7ef7c3d3-6bbd-4395-b0ef-03fdb272b69a

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code F14 labels Feb 27, 2025
@dtscalac dtscalac added this to the Fund14 Technical Readiness milestone Feb 27, 2025
@dtscalac dtscalac self-assigned this Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 588/593}$ | ${\color{red}Fail: 0/593}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 588/593}$ | ${\color{red}Fail: 0/593}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 588/593}$ | ${\color{red}Fail: 0/593}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 592/597}$ | ${\color{red}Fail: 0/597}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 592/597}$ | ${\color{red}Fail: 0/597}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 592/597}$ | ${\color{red}Fail: 0/597}$ |

damian-molinski
damian-molinski previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/export-proposal to main February 28, 2025 12:09
@dtscalac dtscalac dismissed damian-molinski’s stale review February 28, 2025 12:09

The base branch was changed.

@dtscalac
Merge branch 'main' into feat/import-proposal
336a5d4 
# Conflicts:
#	catalyst_voices/apps/voices/lib/pages/workspace/header/import_proposal_button.dart
#	catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/proposal_builder/proposal_builder_bloc.dart
#	catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/proposal_builder/proposal_builder_state.dart
#	catalyst_voices/packages/internal/catalyst_voices_repositories/lib/src/document/document_repository.dart
#	catalyst_voices/packages/internal/catalyst_voices_services/lib/src/proposal/proposal_service.dart
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 592/597}$ | ${\color{red}Fail: 0/597}$ |

@dtscalac dtscalac merged commit 19d6ae6 into main Feb 28, 2025
40 checks passed
@dtscalac dtscalac deleted the feat/import-proposal branch February 28, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@LynxLynxx LynxLynxx Awaiting requested review from LynxLynxx LynxLynxx is a code owner

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code F14 review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
Fund14 Technical Readiness
Development

Successfully merging this pull request may close these issues.

Implement Import Proposal Functionality in Proposal Index
3 participants
@dtscalac @damian-molinski @LynxLynxx