Skip to content

Commit

Permalink
refactor: cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
jmgilman committed Sep 14, 2024
1 parent 38c4662 commit 9ffe203
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
1 change: 0 additions & 1 deletion forge/cli/cmd/cmds/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,5 @@ func (c *RunCmd) Run(logger *slog.Logger) error {
}

printJson(result, c.Pretty)

return nil
}
2 changes: 1 addition & 1 deletion forge/cli/cmd/cmds/scan.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type ScanCmd struct {

func (c *ScanCmd) Run(logger *slog.Logger) error {
walker := walker.NewDefaultFSWalker(logger)
loader := project.NewDefaultProjectLoader(loadRuntimes(logger), logger)
loader := project.NewDefaultProjectLoader(project.GetDefaultRuntimes(logger), logger)

var rootPath string
if c.Absolute {
Expand Down
9 changes: 1 addition & 8 deletions forge/cli/cmd/cmds/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,10 @@ func generateOpts(flags *RunCmd) []earthly.EarthlyExecutorOption {

// loadProject loads the project from the given root path.
func loadProject(rootPath string, logger *slog.Logger) (project.Project, error) {
loader := project.NewDefaultProjectLoader(loadRuntimes(logger), logger)
loader := project.NewDefaultProjectLoader(project.GetDefaultRuntimes(logger), logger)
return loader.Load(rootPath)
}

// loadRuntimes loads the all runtime data collectors.
func loadRuntimes(logger *slog.Logger) []project.RuntimeData {
return []project.RuntimeData{
project.NewGitRuntime(logger),
}
}

// printJson prints the given data as a JSON string.
func printJson(data interface{}, pretty bool) {
var out []byte
Expand Down
8 changes: 8 additions & 0 deletions forge/cli/pkg/project/runtime.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,16 @@ func (g *GitRuntime) Load(project *Project) map[string]string {
return data
}

// NewGitRuntime creates a new GitRuntime.
func NewGitRuntime(logger *slog.Logger) *GitRuntime {
return &GitRuntime{
logger: logger,
}
}

// GetDefaultRuntimes returns the default runtime data loaders.
func GetDefaultRuntimes(logger *slog.Logger) []RuntimeData {
return []RuntimeData{
NewGitRuntime(logger),
}
}

0 comments on commit 9ffe203

Please sign in to comment.