-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-extension): detect bg script when on firefox - LW-11944 #1580
feat(web-extension): detect bg script when on firefox - LW-11944 #1580
Conversation
there are some unit tests failing. I will fix them shortly |
74443fd
to
029cc2c
Compare
029cc2c
to
537ad7c
Compare
Firefox runs background script in a hidden page, so it has a window object.
537ad7c
to
b4b540d
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context
Make bg script detection more robust
Firefox runs background script in a hidden page,
so it has a window object.
Proposed Solution
Check for
runtime.getBackgroundPage
function which exists in firefox only on background page.Important Changes Introduced