Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added TYPE static field and enhanced tests #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bdgould
Copy link
Member

@bdgould bdgould commented Feb 28, 2025

Added a static field on each generated interface for the type IRI as a string :)

@bdgould bdgould removed their assignment Feb 28, 2025
@mnmercer mnmercer self-requested a review February 28, 2025 22:51
@mnmercer mnmercer assigned bdgould and unassigned mnmercer Feb 28, 2025
@mnmercer
Copy link
Contributor

mnmercer commented Mar 3, 2025

Is there anyway to make the TYPE field be of type IRI instead of String?

@bdgould
Copy link
Member Author

bdgould commented Mar 3, 2025

I'm not sure it's a great idea actually, since we'd need a ValueFactory to produce the IRI. The rest of the system relies on a configured ValueFactory to be passed into the ThingFactory implementation for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants