pantab 4.0 #218
Merged
pantab 4.0 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
force-pushed
the
use-cmake
branch
2 times, most recently
from
734c575 to
505ddeb
Compare
WillAyd
commented
Jan 8, 2024
pantab/tests/conftest.py
Outdated
| @@ -59,15 +57,15 @@ def df(): | |||
| 0, | |||
| 0, | |||
| 0, | |||
| # np.nan, | |||
There was a problem hiding this comment.
These are commented out because of a bug upstream in pandas. see pandas-dev/pandas#56777
WillAyd
commented
Jan 8, 2024
pantab/tests/conftest.py
Outdated
| "datetime64_utc", | ||
| "timedelta64", | ||
| # "datetime64_utc", | ||
| # "timedelta64", |
There was a problem hiding this comment.
timedelta support will be broken in 4.0. the pandas buffer interface doesn't send it, and there is some ambiguiuty across different libraries as to how this is managed anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #xxx