Remove numpy build dependency (#315)

innobi · Aug 17, 2024 · d760e91 · d760e91
1 parent f00413e
commit d760e91
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 545 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -10,7 +10,7 @@ else()
     add_compile_options(-Wall -Wextra -Werror)
 endif()
 
-find_package(Python COMPONENTS Interpreter Development.Module NumPy REQUIRED)
+find_package(Python COMPONENTS Interpreter Development.Module REQUIRED)
 
 # Detect the installed nanobind package and import it into CMake
 execute_process(

diff --git a/NUMPY_LICENSE.txt b/NUMPY_LICENSE.txt
diff --git a/pyproject.toml b/pyproject.toml
@@ -2,7 +2,6 @@
 requires = [
   "scikit-build-core",
   "nanobind",
-  "oldest-supported-numpy",  # only needed for datetime
 ]
 build-backend = "scikit_build_core.build"
 
@@ -69,7 +68,7 @@ build = "cp39-*64 cp310-*64 cp311-*64 cp312-*64"
 skip = "*musllinux*"
 
 test-command = "pytest {project}/tests"
-test-requires = ["pytest", "pandas>=2.0.0", "polars<1.3.0", "narwhals", "numpy"]
+test-requires = ["pytest", "pandas>=2.0.0", "polars<1.3.0", "narwhals"]
 
 [tool.ruff]
 line-length = 88

diff --git a/src/pantab/CMakeLists.txt b/src/pantab/CMakeLists.txt
@@ -2,7 +2,6 @@ set(PANTAB_SOURCES
   libpantab.cpp
   reader.cpp
   writer.cpp
-  numpy_datetime.cpp
 )
 if(WIN32)
   # Required so local installation of pantab can resolve to bundled
@@ -17,7 +16,6 @@ nanobind_add_module(
   NOMINSIZE
   ${PANTAB_SOURCES}
 )
-target_include_directories(libpantab PUBLIC ${Python_NumPy_INCLUDE_DIRS})
 target_link_libraries(libpantab
   PRIVATE Tableau::tableauhyperapi-cxx
   PRIVATE nanoarrow