Complete cppcoreguidelines adherence (#391)

innobi · Nov 15, 2024 · 626c117 · 626c117
1 parent 7919c88
commit 626c117
Show file tree

Hide file tree

Showing 3 changed files with 86 additions and 53 deletions.
diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml
@@ -33,7 +33,7 @@ jobs:
         ln -s build/compile_commands.json
     - name: Run clang-tidy
       run: |
-        clang-tidy src/pantab/writer.cpp
+        clang-tidy src/pantab/*.*pp --warnings-as-errors='*'
 
   build_wheels:
     name: Build wheels on ${{ matrix.os }}

diff --git a/src/pantab/numeric_gen.hpp b/src/pantab/numeric_gen.hpp
@@ -1,5 +1,6 @@
 #pragma once
 
+#include <array>
 #include <cstddef>
 #include <utility>
 #include <variant>
@@ -10,7 +11,8 @@
 template <std::size_t N> constexpr auto to_integral_variant(std::size_t n) {
   return [&]<std::size_t... Is>(std::index_sequence<Is...>) {
     using ResType = std::variant<std::integral_constant<std::size_t, Is>...>;
-    ResType all[] = {ResType{std::integral_constant<std::size_t, Is>{}}...};
+    std::array<ResType, N> all{
+        ResType{std::integral_constant<std::size_t, Is>{}}...};
     return all[n];
   }(std::make_index_sequence<N>());
 }