MSVC debug

pyproject.toml

@@ -67,7 +67,7 @@ known_first_party = "pantab"
 build = "cp39-*64 cp310-*64 cp311-*64 cp312-*64"
 skip = "*musllinux*"
 
-test-command = "python -m pytest {project}/tests"
+test-command = "python -m pytest -s {project}/tests/test_decimal.py"
 test-requires = ["pytest", "pandas>=2.0.0", "polars~=1.2.0", "narwhals"]
 
 [tool.ruff]

src/pantab/reader.cpp

@@ -1,5 +1,6 @@
 #include "reader.hpp"
 
+#include <iostream>
 #include <variant>
 #include <vector>
 
@@ -289,10 +290,10 @@ class DecimalReadHelper : public ReadHelper {
           if constexpr (S() <= P()) {
             const auto decimal_value = value.get<hyperapi::Numeric<P(), S()>>();
             auto value_string = decimal_value.toString();
-            // C++20 std::erase would really simplify this!
-            value_string.erase(
-                std::remove(value_string.begin(), value_string.end(), '.'),
-                value_string.end());
+            std::cout << std::endl
+                      << "Original value string is: " << value_string
+                      << std::endl;
+            std::erase(value_string, '.');
             return value_string;
           }
           throw "unreachable";

src/pantab/writer.cpp

@@ -4,6 +4,7 @@
 #include <nanoarrow/nanoarrow.hpp>
 
 #include <chrono>
+#inlcude < iostream>
 #include <set>
 #include <utility>
 #include <variant>
@@ -373,6 +374,8 @@ class DecimalInsertHelper : public InsertHelper {
     // The Hyper API wants the string to include the decimal place, which
     // nanoarrow does not provide
     const auto str_with_decimal = str.insert(str.size() - scale_, 1, '.');
+    std::cout << std::endl
+              << "str_with_decimal is: " << str_with_decimal << std::endl;
 
     constexpr auto MaxPrecision = 39; // of-by-one error in solution?
     if (precision_ >= MaxPrecision) {