Fix criteria for translating a function to an action #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While translations with `Deps` are pure helper defs
bugarela
force-pushed
the
gabriela/fix-action-criteria
branch
from
042f7d6 to
ef1a9ef
Compare
p-offtermatt
approved these changes
Apr 10, 2024
It would be helpful, but your repo is private (and I don't know for how long this one will stay private), and Ivan's is way too big, so I think not worth it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Closes #15
We now only translate functions with
DepsMutas actions, while functions withDepsare translated to pure helper definitions.This doesn't have an impact on any CTF contract (so, in our snapshot tests), but it fixes a problem that both @p-offtermatt and @ivan-gavran hit. I manually checked that this fixes those.