DEVOPS-30441: fix resource status check

infobloxopen · Dec 31, 2024 · 5c0720d · 5c0720d
1 parent ec8cfac
commit 5c0720d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/pkg/databaseclaim/databaseclaim.go b/pkg/databaseclaim/databaseclaim.go
@@ -1039,10 +1039,11 @@ func (r *DatabaseClaimReconciler) getPasswordRotationTime() time.Duration {
 
 // FindStatusCondition finds the conditionType in conditions.
 func (r *DatabaseClaimReconciler) isResourceReady(typ, name string, resourceStatus xpv1.ResourceStatus) (bool, error) {
-	if ok, err := isResourceReady(resourceStatus); err != nil {
-		return ok, fmt.Errorf("%s %s: %w", typ, name, err)
+	ok, err := isResourceReady(resourceStatus)
+	if err != nil {
+		return false, fmt.Errorf("%s %s: %w", typ, name, err)
 	}
-	return true, nil
+	return ok, nil
 }
 
 func isResourceReady(resourceStatus xpv1.ResourceStatus) (bool, error) {