Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve waitForStateCompletion error handling #363

Merged
merged 10 commits into from
Feb 21, 2024

improve wait workflow timeout

88fd9e6
Select commit
Loading
Failed to load commit list.
Merged

Fix/improve waitForStateCompletion error handling #363

improve wait workflow timeout
88fd9e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 21, 2024 in 1s

71.90% (-0.13%) compared to 91b683d

View this Pull Request on Codecov

71.90% (-0.13%) compared to 91b683d

Details

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (91b683d) 72.02% compared to head (88fd9e6) 71.90%.

Files Patch % Lines
service/api/service.go 42.85% 7 Missing and 1 partial ⚠️
service/interpreter/workflowImpl.go 66.66% 2 Missing and 1 partial ⚠️
service/api/cadence/client.go 94.73% 1 Missing ⚠️
service/api/temporal/client.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   72.02%   71.90%   -0.13%     
==========================================
  Files          56       56              
  Lines        4937     4954      +17     
==========================================
+ Hits         3556     3562       +6     
- Misses       1119     1129      +10     
- Partials      262      263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.