fix

indeedeng · Dec 6, 2024 · dda96dd · dda96dd
1 parent b2a853e
commit dda96dd
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 28 deletions.
diff --git a/integ/run_server_for_debug_test.go b/integ/run_server_for_debug_test.go
@@ -8,7 +8,7 @@ import (
 
 // remove the underscore to run
 // nolint
-func TestNothingButJustRunningTheServiceTemporalWorkerForDebug(t *testing.T) {
+func _TestNothingButJustRunningTheServiceTemporalWorkerForDebug(t *testing.T) {
 	startIwfServiceWithClient(service.BackendTypeTemporal)
 	time.Sleep(time.Hour)
 }
diff --git a/integ/util.go b/integ/util.go
@@ -3,7 +3,6 @@ package integ
 import (
 	cadenceapi "github.com/indeedeng/iwf/service/client/cadence"
 	temporalapi "github.com/indeedeng/iwf/service/client/temporal"
-	"github.com/indeedeng/iwf/service/common/ptr"
 	"log"
 	"net/http"
 	"time"
@@ -225,13 +224,6 @@ func minimumContinueAsNewConfigV0() *iwfidl.WorkflowConfig {
 	return minimumContinueAsNewConfig(false)
 }
 
-func minimumContinueAsNewConfigV1() *iwfidl.WorkflowConfig {
-	return &iwfidl.WorkflowConfig{
-		ContinueAsNewThreshold:       iwfidl.PtrInt32(1),
-		ContinueAsNewPageSizeInBytes: ptr.Any(int32(1000)),
-	}
-}
-
 func getBackendTypes() []service.BackendType {
 	backendTypesToTest := []service.BackendType{}
 

diff --git a/service/interpreter/continueAsNewer.go b/service/interpreter/continueAsNewer.go
@@ -52,8 +52,7 @@ func LoadInternalsFromPreviousRun(
 	ctx UnifiedContext, provider WorkflowProvider, previousRunId string, continueAsNewPageSizeInBytes int32,
 ) (*service.ContinueAsNewDumpResponse, error) {
 	activityOptions := ActivityOptions{
-		// default timeout is 30 seconds, but configurable in DumpWorkflowInternalActivityConfig config
-		StartToCloseTimeout: 30 * time.Second,
+		StartToCloseTimeout: 5 * time.Second,
 		RetryPolicy: &iwfidl.RetryPolicy{
 			MaximumIntervalSeconds: iwfidl.PtrInt32(5),
 		},
@@ -114,9 +113,6 @@ func LoadInternalsFromPreviousRun(
 	return &resp, nil
 }
 
-var lastRunId = ""
-var lastWholeData = ""
-
 func (c *ContinueAsNewer) SetQueryHandlersForContinueAsNew(ctx UnifiedContext) error {
 	return c.provider.SetQueryHandler(ctx, service.ContinueAsNewDumpQueryType,
 		func(request iwfidl.WorkflowDumpRequest) (*iwfidl.WorkflowDumpResponse, error) {
@@ -142,20 +138,6 @@ func (c *ContinueAsNewer) SetQueryHandlersForContinueAsNew(ctx UnifiedContext) e
 			if err != nil {
 				return nil, err
 			}
-			runId := c.provider.GetWorkflowInfo(ctx).CurrentRunID
-			if lastRunId == "" || lastRunId != runId {
-				lastRunId = runId
-				lastWholeData = string(wholeData)
-			} else {
-				if lastRunId == runId {
-					if lastWholeData != string(wholeData) {
-						fmt.Println("issues with marshaling order")
-						fmt.Println(runId)
-						fmt.Println(string(wholeData))
-						fmt.Println(string(lastWholeData))
-					}
-				}
-			}
 			checksum := md5.Sum(wholeData)
 			pageSize := int32(service.DefaultContinueAsNewPageSizeInBytes)
 			if request.PageSizeInBytes > 0 {