Skip to content

Commit

Permalink
IWF-511: Split Error Details work to another ticket
Browse files Browse the repository at this point in the history
  • Loading branch information
samuel27m committed Feb 11, 2025
1 parent 05c8b34 commit 1de81be
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
8 changes: 2 additions & 6 deletions service/client/cadence/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,8 @@ func (t *cadenceClient) GetApplicationErrorDetails(err error, detailsPtr interfa

func (t *cadenceClient) GetApplicationErrorTypeAndDetails(err error) (string, string) {
errType := t.GetApplicationErrorTypeIfIsApplicationError(err)
var errDetails string
detailErr := t.GetApplicationErrorDetails(err, &errDetails)
if detailErr != nil {
errDetails = detailErr.Error()
}
return errType, errDetails
// TODO: Error Details will be added under IWF-511
return errType, ""
}

func NewCadenceClient(
Expand Down
8 changes: 2 additions & 6 deletions service/client/temporal/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,8 @@ func (t *temporalClient) GetApplicationErrorDetails(err error, detailsPtr interf

func (t *temporalClient) GetApplicationErrorTypeAndDetails(err error) (string, string) {
errType := t.GetApplicationErrorTypeIfIsApplicationError(err)
var errDetails string
detailErr := t.GetApplicationErrorDetails(err, &errDetails)
if detailErr != nil {
errDetails = detailErr.Error()
}
return errType, errDetails
// TODO: Error Details will be added under IWF-511
return errType, ""
}

func (t *temporalClient) StartInterpreterWorkflow(
Expand Down

0 comments on commit 1de81be

Please sign in to comment.