-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow safe files on certain subdomains #63
Allow safe files on certain subdomains #63
Conversation
Unbox is now the only way to play Quest for the Teacup of Minor Sentimental Value online. I propose that we merge this PR. |
I guess this is a good idea. Except, the file got renamed. It is now (See https://ifarchive.org/indexes/if-archive/games/competition2024/ .) I have added the DNS records for that subdomain with Cloudflare proxying on:
We can deploy this change to unbox (with the corrected hash). I suppose then we'll need to clear a bunch of Cloudflare cache entries, because the media files will have been cached as redirects by the time the unbox change goes live. |
8769fe8
to
7bd5177
Compare
I've updated my PR to use the new subdomain. But note that the Cloudflare settings that @erkyrath added seems to have broken the page. If you click the “Open www/index.html” button, it will take you to https://2k788xeots.unbox.ifarchive.org/2k788xeots/www/index.html? which displays an error for me in Chrome and Safari.
|
@erkyrath explained:
So, uh, let's deploy this! |
The nginx cache will likely also need to be cleared. |
Sounds like we should merge #65, too! |
Damon posted on intfiction asking about this. https://intfiction.org/t/issue-with-ifcomp-game-on-ifdb-lf-archive/72317 Can we deploy this? |
Fixes #61
In #62, I wrote a PR to allow safe files on all subdomains, but @erkyrath pointed out the problem with that:
Here, I've taken a different approach. Don't allow safe files on all subdomains, but just on a set of allow-listed subdomains (currently, just the only game that's triggering #61, but, in the future, we could add more.)
Every time we hit a bug like #61, we'd manually add the subdomain to the allow list. And then, we'd go to the Cloudflare admin tool and explicitly enable Cloudflare proxying for that subdomain.
I'm not anticipating that there would be very many of these. (We've only encountered one so far… I'd be surprised if we needed to do more than one a year for the next 10+ years.)
If we don't implement it this way, there is a one-line workaround possible by modifying the game code, described here: #61 (comment)