Use native linux-arm64 runner for GitHub actions (#32)

Use native linux-arm64 runner for GitHub actions
iden3 · Feb 11, 2025 · 54afaa9 · 54afaa9
1 parent b9d6b0e
commit 54afaa9
Showing 1 changed file with 60 additions and 56 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -10,8 +10,8 @@ on:
 
 jobs:
 
-  build-linux:
-    runs-on: ubuntu-22.04
+  build-linux-x86_64:
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
         with:
@@ -21,38 +21,15 @@ jobs:
         uses: awalsh128/cache-apt-pkgs-action@v1
         with:
           packages: build-essential cmake m4 nasm
-          version: 1.0
-
-      - name: Setup QEMU to build ARM64 variant
-        uses: docker/setup-qemu-action@v3
-
-      - name: Setup buildx for ARM64 platform
-        uses: docker/setup-buildx-action@v3
-        with:
-          platforms: linux/amd64,linux/arm64
-
-      - name: Prepare Docker image builder for ARM64
-        uses: docker/build-push-action@v6
-        env:
-          DOCKER_BUILD_SUMMARY: false
-          DOCKER_BUILD_RECORD_UPLOAD: false
-        with:
-          push: false
-          outputs: type=docker
-          platforms: linux/arm64
-          file: .github/images/Dockerfile.build
-          context: ./.github/images/context.build
-          cache-from: type=gha,scope=buildkit-arm64
-          cache-to: type=gha,mode=max,scope=buildkit-arm64
-          tags: builder:arm64
+          version: x86_64-1.0
 
       - name: Cache gmp build
         uses: actions/cache@v4
         with:
           path: |
             depends/gmp
             depends/gmp-6.2.1.tar.xz
-          key: ${{ runner.os }}-gmp-${{ hashFiles('build_gmp.sh') }}-4
+          key: ${{ runner.os }}-${{ runner.arch }}-gmp-${{ hashFiles('build_gmp.sh') }}
 
       - name: Build gmp for Android arm64
         run: if [[ ! -d "depends/gmp/package_android_arm64" ]]; then ./build_gmp.sh android; fi
@@ -63,12 +40,6 @@ jobs:
       - name: Build gmp for Linux x86_64
         run: if [[ ! -d "depends/gmp/package" ]]; then ./build_gmp.sh host; fi
 
-      - name: Build gmp for Linux arm64
-        run: |
-          if [[ ! -d "depends/gmp/package_aarch64" ]]; then
-            docker run --rm --platform=linux/arm64 -i -v $PWD:/work --workdir=/work builder:arm64 ./build_gmp.sh aarch64
-          fi
-
       - name: Build prover Android ARM64
         run: |
           mkdir -p build_prover_android && cd build_prover_android
@@ -107,18 +78,6 @@ jobs:
           make -j4 && make install
           ctest --rerun-failed --output-on-failure
 
-      - name: Build prover Linux arm64
-        run: |
-          docker run --rm --platform=linux/arm64 -i -v $PWD:/work --workdir=/work builder:arm64 bash -c "$(cat << 'EOF'
-            set -x
-            set -e
-            mkdir -p build_prover_arm64 && cd build_prover_arm64
-            cmake .. -DTARGET_PLATFORM=aarch64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=../package_arm64
-            make -j4 && make install
-            ctest --rerun-failed --output-on-failure
-          EOF
-          )"
-
       - name: Test rapidsnark
         run: |
           set -x
@@ -151,15 +110,6 @@ jobs:
             package_noasm
           if-no-files-found: error
 
-      - name: Upload Linux arm64 dev artifacts
-        if: github.event_name != 'release'
-        uses: actions/upload-artifact@v4
-        with:
-          name: rapidsnark-linux-arm64
-          path: |
-            package_arm64
-          if-no-files-found: error
-
       - name: Upload Android dev artifacts
         if: github.event_name != 'release'
         uses: actions/upload-artifact@v4
@@ -240,6 +190,60 @@ jobs:
           zip -r rapidsnark-linux-x86_64-noasm-${{ github.ref_name }}.zip rapidsnark-linux-x86_64-noasm-${{ github.ref_name }}
           gh release upload ${{ github.event.release.tag_name }} rapidsnark-linux-x86_64-noasm-${{ github.ref_name }}.zip
 
+  build-linux-arm64:
+    runs-on: ubuntu-24.04-arm
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: "recursive"
+
+      - name: install requirements
+        uses: awalsh128/cache-apt-pkgs-action@v1
+        with:
+          packages: build-essential cmake m4 nasm
+          version: arm64-1.0
+
+      - name: Cache gmp build
+        uses: actions/cache@v4
+        with:
+          path: |
+            depends/gmp
+            depends/gmp-6.2.1.tar.xz
+          key: ${{ runner.os }}-${{ runner.arch }}-gmp-${{ hashFiles('build_gmp.sh') }}
+
+      - name: Build gmp for Linux arm64
+        run: if [[ ! -d "depends/gmp/package_aarch64" ]]; then ./build_gmp.sh aarch64; fi
+
+      - name: Build prover Linux arm64
+        run: |
+          mkdir -p build_prover_arm64 && cd build_prover_arm64
+          cmake .. -DTARGET_PLATFORM=aarch64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=../package_arm64
+          make -j4 && make install
+          ctest --rerun-failed --output-on-failure
+
+      - name: Test rapidsnark
+        run: |
+          set -x
+          set -e
+          time package_arm64/bin/prover testdata/circuit_final.zkey testdata/witness.wtns proof.json public.json
+          time package_arm64/bin/verifier testdata/verification_key.json public.json proof.json
+          # make a wrong public.json by decrementing the first element by 1
+          (value_0=$(jq '.[0]' public.json | tr -d '"') && value_0=$(echo "$value_0 - 1" | BC_LINE_LENGTH=100 bc) && jq --arg value_0 "$value_0" '.[0] = $value_0' public.json) > public_bad.json
+          set +e
+          time package_arm64/bin/verifier testdata/verification_key.json public_bad.json proof.json
+          exit_code=$?
+          set -e
+          [ $exit_code -ne 0 ]
+
+      - name: Upload Linux arm64 dev artifacts
+        if: github.event_name != 'release'
+        uses: actions/upload-artifact@v4
+        with:
+          name: rapidsnark-linux-arm64
+          path: |
+            package_arm64
+          if-no-files-found: error
+
       - name: Upload Linux ARM64 release artifacts
         if: github.event_name == 'release'
         env:
@@ -264,7 +268,7 @@ jobs:
           path: |
             depends/gmp
             depends/gmp-6.2.1.tar.xz
-          key: ${{ runner.os }}-gmp-arm64-${{ hashFiles('build_gmp.sh') }}
+          key: ${{ runner.os }}-${{ runner.arch }}-gmp-${{ hashFiles('build_gmp.sh') }}
 
       - name: build
         run: |
@@ -378,7 +382,7 @@ jobs:
           path: |
             depends/gmp
             depends/gmp-6.2.1.tar.xz
-          key: ${{ runner.os }}-gmp-x86_64-${{ hashFiles('build_gmp.sh') }}-2
+          key: ${{ runner.os }}-${{ runner.arch }}-gmp-${{ hashFiles('build_gmp.sh') }}
 
       - name: install dependencies
         run: |