Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimums as percents #361

Merged
merged 2 commits into from
Jun 7, 2024
Merged

minimums as percents #361

merged 2 commits into from
Jun 7, 2024

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented May 21, 2024


Pull Request Description

DO NOT MERGE -> changes should be integrated into the DOVE migration.

What issue does this change request address?

Closes #338.

What are the significant changes in functionality due to this change request?

Changes minimums to be read in as a percentage of the installed capacity, instead of a real value. This also removes the need for the "resource" specifier on the minimum.

Changed the minimum production test to (1) be debug, so we can check the dispatch, and (2) not use ARMA as the minimum, for clearer results.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL added the Do Not Merge PR is not ready for merging label May 21, 2024
@PaulTalbot-INL
Copy link
Collaborator Author

@dylanjm this may actually not impact DOVE; if so, we can merge this when you have time to review it.

@dylanjm
Copy link
Collaborator

dylanjm commented May 21, 2024

@PaulTalbot-INL Since we moved Components over to DOVE it will affect, but since it's small enough, we can go ahead and merge it and I will make the neccesary updates to the Components file over in DOVE.

@PaulTalbot-INL PaulTalbot-INL changed the title [WIP] minimums as percents minimums as percents May 21, 2024
@PaulTalbot-INL PaulTalbot-INL removed the Do Not Merge PR is not ready for merging label May 21, 2024
Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good to merge and I will address these changes in the DOVE repo by hand.

@dylanjm dylanjm merged commit 9a40121 into idaholab:devel Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Allow <minimum> to be specified as a percent instead of absolute terms
2 participants