Bayesian Opt input structure fix

[GabrielSoto-INL]

---

Pull Request Description

What issue does this change request address?

#350 , #355

What are the significant changes in functionality due to this change request?

1. Fixes a previous issue in template_driver.py where if the user requests usage of the BayesianOpt optimization algorithm/strategy, it still writes a GradientDescent node into the outer.xml.

2. There are modifications to the XML input node under the Cases -> optimization_settings -> algorithm node. The <algorithm> node accepts subnodes rather than a string for either <GradientDescent> or <BayesianOpt>. Each now has algorithm-specific settings that can be modified by the user (all available in the HERON user manual). Default is still <BayesianOpt>.

3. Some features available in the outer.xml for <GradientDescent> are now able to be modified in the heron input script as described in [TASK] Access GradientDescent Features in HERON input script #355.

4. Updated some of the scripts for checking XMLs; regolding 'optimization_settings' test to change from Gradient Descent to Bayesian Opt results (larger tolerance, shorter duration)

---

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

• 1. Review all computer code.
• 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
• 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
• 4. Automated Tests should pass.
• 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
• 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
• 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
• 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
• 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

[PaulTalbot-INL]

I'm fine with initialSeed; if at some point you want to change this to seed while making other changes, I slightly prefer that.

[GabrielSoto-INL]

eh, might as well change it now. it'll be seed for the HERON input, but I think it has to still be initialSeed in the outer.xml unless we modify the RAVEN input structure

[PaulTalbot-INL]

sure, that's fine. We intentionally split HERON syntax from RAVEN syntax most of the time, since much of the purpose of the HERON input was to make it more accessible than the RAVEN running RAVEN inputs that Aaron originally wrote. This is not a big deal, but I like the cleanness of the change. Thanks!

[PaulTalbot-INL]

Just one commented line to consider.

[PaulTalbot-INL]

do we want to keep this line?

[GabrielSoto-INL]

Nope! will delete

[PaulTalbot-INL]

Checklist passes, merging.

We've had enough little changes as well as big fixes like this one, it might be time for a submodule update in RAVEN; @GabrielSoto-INL would you mind opening one?