Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement post conditions & support smart contract clarity version #36

Merged

Conversation

bestmike007
Copy link
Contributor

This PR is adding the missing part of stacks transactions:

  • Added post condition support
  • Added versioned smart contract

Copy link
Contributor

@CyrusVorwald CyrusVorwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but the changes are currently unused in the transactions. Would like to know more about what you are doing that led to this PR if you don't mind sharing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be post condition integration tests

@bestmike007
Copy link
Contributor Author

I'm adding all these because we also use the SDK to parse onchain transactions and index some of them. So these are must-haves. Besides, VersionedSmartContract is the default now, and most App uses post-conditions to ensure the asset security.

This PR is WIP, I'll continue work on this if you think it's on the right direction. And let me know if you want me to split it into smaller PRs.

@bestmike007 bestmike007 force-pushed the feat/implement-post-conditions branch from a8a1490 to 529790d Compare November 23, 2024 06:58
@CyrusVorwald CyrusVorwald merged commit 5df9172 into icon-project:main Nov 26, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants