-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement post conditions & support smart contract clarity version #36
feat: implement post conditions & support smart contract clarity version #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but the changes are currently unused in the transactions. Would like to know more about what you are doing that led to this PR if you don't mind sharing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be post condition integration tests
I'm adding all these because we also use the SDK to parse onchain transactions and index some of them. So these are must-haves. Besides, VersionedSmartContract is the default now, and most App uses post-conditions to ensure the asset security. This PR is WIP, I'll continue work on this if you think it's on the right direction. And let me know if you want me to split it into smaller PRs. |
a8a1490
to
529790d
Compare
This PR is adding the missing part of stacks transactions: