Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sui contract #1

Merged
merged 17 commits into from
Nov 5, 2024
Merged

feat: sui contract #1

merged 17 commits into from
Nov 5, 2024

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Sep 20, 2024

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@ibrizsabin ibrizsabin self-assigned this Sep 20, 2024
@ibrizsabin ibrizsabin added the enhancement New feature or request label Sep 25, 2024
Copy link

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minors. Looks good

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@81f4cbd). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   88.41%           
=======================================
  Files           ?        7           
  Lines           ?      535           
  Branches        ?        0           
=======================================
  Hits            ?      473           
  Misses          ?       62           
  Partials        ?        0           
Flag Coverage Δ
solidity 88.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@gcranju gcranju merged commit c7dae72 into main Nov 5, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants