Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add function to manually configure available amounts #11

Merged
merged 2 commits into from
May 3, 2024

Conversation

AntonAndell
Copy link
Collaborator

New orders will defult to 0 and current order will keep their current amount, configuring a order should now only affect the rate in which it gains more availbable for purschase

@AntonAndell AntonAndell linked an issue Apr 30, 2024 that may be closed by this pull request
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.04%. Comparing base (a544e62) to head (bf91264).

Files Patch % Lines
...con/inflation/score/nol/NetworkOwnedLiquidity.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #11      +/-   ##
============================================
- Coverage     78.10%   78.04%   -0.07%     
- Complexity       41       42       +1     
============================================
  Files             6        6              
  Lines           201      205       +4     
  Branches         14       15       +1     
============================================
+ Hits            157      160       +3     
  Misses           39       39              
- Partials          5        6       +1     
Flag Coverage Δ
java 78.04% <92.30%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcsainju bcsainju self-requested a review May 2, 2024 06:21
Copy link
Collaborator

@bcsainju bcsainju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntonAndell AntonAndell force-pushed the 10-configure-initial-buy-limits-for-nol-contract branch from 8d5db77 to f16ca34 Compare May 3, 2024 05:12
New orders will defult to 0 and current order will keep their current amount, configuring a order should now only affect the rate in which it gains more availbable for purschase
@AntonAndell AntonAndell force-pushed the 10-configure-initial-buy-limits-for-nol-contract branch from f16ca34 to bf91264 Compare May 3, 2024 05:18
@AntonAndell AntonAndell merged commit adc1c0c into main May 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure initial buy limits for NOL contract
3 participants