Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix reentrancy #871

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: fix reentrancy #871

merged 2 commits into from
Aug 5, 2024

Conversation

ibrizsabin
Copy link
Collaborator

@ibrizsabin ibrizsabin commented Aug 5, 2024

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@ibrizsabin ibrizsabin self-assigned this Aug 5, 2024
@ibrizsabin ibrizsabin added the bug Something isn't working label Aug 5, 2024
@ibrizsabin ibrizsabin changed the title fix: fix timeout reentrancy fix: fix reentrancy Aug 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.29%. Comparing base (c277c32) to head (9138b4d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #871   +/-   ##
=========================================
  Coverage     76.28%   76.29%           
  Complexity      418      418           
=========================================
  Files           155      155           
  Lines         14447    14452    +5     
  Branches        292      292           
=========================================
+ Hits          11021    11026    +5     
  Misses         3279     3279           
  Partials        147      147           
Flag Coverage Δ
java 81.53% <100.00%> (ø)
rust 75.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-core/src/ics04_channel/packet/timeout_on_close.rs 100.00% <100.00%> (ø)
.../main/java/ibc/ics25/handler/IBCHandlerPacket.java 98.11% <100.00%> (ø)

Install docker-compose
@github-actions github-actions bot added the cicd label Aug 5, 2024
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrizsabin ibrizsabin merged commit 987dcee into main Aug 5, 2024
15 checks passed
@ibrizsabin ibrizsabin deleted the fix/timeout-reentrancy-fix branch August 5, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cicd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants